Snaji/create persipubsub - #1

Hi Selim

I only reviewed the readme file. I'll work on the rest in the afternoon

Adam

Review part 1

1. You need to decide whether publisher sends messages to the subscriber, or maybe it only writes messages to the queue and then subscriber read them. Once you make up your mind you should make sure that all the comments are consistent (some of my suggestions might not apply then)

2. Please explain what exactly happens in get_queue_data function offline. Maybe there is a way to not have this function

Hi Selim,

The code looks really good! There are only minor comments and changes. You did great work.

I reviewed up to tests. More comes tomorrow afternoon

Two comments for now

1. You need to decide whether publisher sends messages to the subscriber, or maybe it only writes messages to the queue and then subscriber read them. Once you make up your mind you should make sure that all the comments are consistent (some of my suggestions might not apply then)
2. Please explain what exactly happens in get_queue_data function offline. Maybe there is a way to not have this function

Adam

Hi Selim,
I looked at the unit tests. they are very nicely structured and clearly written. I think there is no need to do any big changes. Please see minor 2 comments below

Adam